Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: with the new infra update LOCAL_LAMBDA_ENDPOINT is now replaced by LOCAL_AWS_ENDPOINT #3019

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: with the new infra update LOCAL_LAMBDA_ENDPOINT is now replaced by LOCAL_AWS_ENDPOINT #3019

merged 1 commit into from
Dec 11, 2023

Conversation

craigzour
Copy link
Contributor

Summary | Résumé

  • With the new infra update we can now only use specific AWS endpoint for the whole application

@craigzour craigzour self-assigned this Dec 11, 2023
@craigzour craigzour enabled auto-merge (squash) December 11, 2023 16:06
@github-actions GitHub Actions
Copy link
Contributor

🧪 Review environment

https://pzpxpsmwtq6qj7aqbbfy6tdb240odref.lambda-url.ca-central-1.on.aws/

thiessenp-cds
thiessenp-cds approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@craigzour craigzour merged commit 47c2d24 into develop Dec 11, 2023
11 checks passed
@craigzour craigzour deleted the chore/aws-var-env branch December 11, 2023 16:23
@sre-read-write sre-read-write bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiessenp-cds thiessenp-cds thiessenp-cds approved these changes

@timarney timarney Awaiting requested review from timarney

@dsamojlenko dsamojlenko Awaiting requested review from dsamojlenko

Assignees

@craigzour craigzour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigzour @thiessenp-cds