New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: question selector dropdown fix #3126

Merged

timarney merged 1 commit into develop from filter-questions-in-modal

Jan 18, 2024

Member

timarney commented Jan 18, 2024 •

edited

Loading

Summary | Résumé

Fixes question selector for modal rules

Fix for Richtext field to use description vs title
Fix to use correct language key
Fix to filter out currently selected question.

Before:

After:


          add filter

ac32f4d

Contributor

github-actions bot commented Jan 18, 2024

🧪 Review environment

https://s2d2ek7f6dzc3m3rd3246ucyh40fvqqj.lambda-url.ca-central-1.on.aws/

thiessenp-cds approved these changes

View reviewed changes

Contributor

thiessenp-cds left a comment

LGTM :)

timarney merged commit 24411c1 into develop

11 checks passed

timarney deleted the filter-questions-in-modal branch

January 18, 2024 15:09

sre-read-write bot mentioned this pull request

chore: GCForms release v3.12.0 #3080

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet