-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove Service Account from Zitadel when API key is deleted. #3908
Conversation
…platform-forms-client into feature/service_account
…lient into feature/service_account
…platform-forms-client into feature/service_account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will now test it before approving but I can already share a few comments I added to your PR
components/clientComponents/forms/Description/Description.test.js
Outdated
Show resolved
Hide resolved
I tested your PR locally and it does work well (including the delete template scenario with the right flag). I know you mentioned that client errors are not yet implemented but I still wanted to share a scenario I tested, just out of curiosity, and that revealed a possible problem for the future. Let's say you have a form with an active API service account linked associated to it. You decide to manually delete that account through the Zitadel console then you go back to the web application and refresh the page. You will see that the API key does not exist anymore but if you try to create a new one you will get a database conflict because the previous one is still in there. |
Summary | Résumé
This PR adds the functionality to:
Other file changes that were part of small refactoring while going through the code base:
Test instructions | Instructions pour tester la modification
*Must have an account on Zitadel in Staging
Unresolved questions / Out of scope | Questions non résolues ou hors sujet
User Errors back to the interface are currently out of scope while we wait for designs on how the API Settings should be created.
Pull Request Checklist
Please complete the following items in the checklist before you request a review: