fix: add toggle right panel from logic view nodes #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://hfnvwnmwsput3xpdxuhyegm55m0enzsw.lambda-url.ca-central-1.on.aws/ |
thiessenp-cds
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Nice work. LGTM :)
For a follow up PR it looks like we could do some work on focus management. Like when closing the right panel, thinking where the focus should go. Also, when the right panel slides into view, this is not announced to a screen reader. (should be fixed at some point)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
fixes: #3918
Fixes issue where the right panel should open when clicking to add a rule from a group node.
Kapture.2024-07-10.at.13.18.59.mp4