-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client feature flags #4302
Conversation
🧪 Review environmenthttps://pr4fim3gms3oiwkwmjvsvjw55e0eigqw.lambda-url.ca-central-1.on.aws/ |
We'll need to update the form filler page as well as it uses const isAllowGrouping = await allowGrouping(); and passes to
|
Yup, that is one of a number of pages that access that feature flag that way. There is also other feature flags. My plan was to do the forms-forms page and other pages in a followup commit. To me, this seems like less work to review and less chance to miss something in a review. |
Summary | Résumé
Adds a React context provider to allow the client (components) to access feature flags without having to do prop drilling. There is also a slight performance improvement since the feature flags only need to pulled from Redis once per layout/page.
Testing
Test by looking using the new Repeating Sets feature.
First turn off the "Experimental Features" flag in the admin setting. Open the form builder on any form and click the "Add Form Element" button. At the bottom of the dialog there should be no option for Repeating Sets.
Second, turn on the feature, follow the same steps and now the Repeating Sets feature should show in the dialog.