Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow generate SBOM step to fail #4348

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

patheard
Copy link
Member

@patheard patheard commented Oct 1, 2024

Summary

Update the Staging ECR push workflow to allow the generate SBOM step to fail. This step is intermittently failing because the public Trivy Docker image that contains the vulnerability database is being rate limited.

SRE is working on setting up a dedicated ECR for CDS projects to fix this rate limiting in the future.

Test instructions | Instructions pour tester la modification

Expect the generate SBOM step to no longer fail the Staging Docker image build/push workflow.

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

n/a

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Update the Staging ECR push workflow to allow the generate SBOM step
to fail.  This step is intermittently failing because the public Trivy Docker image
that contains the vulnerability database is being rate limited.

SRE is working on setting up a dedicated ECR for CDS projects to fix
this rate limiting in the future.
@patheard patheard self-assigned this Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

@patheard patheard merged commit 53e258d into develop Oct 1, 2024
13 checks passed
@patheard patheard deleted the fix/generate-sbom branch October 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants