Improved error message for server-side file validation errors #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://3hk7ox3mvoz6knuby4tcpofbte0ulrxg.lambda-url.ca-central-1.on.aws/ |
timarney
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Partial fix for #4362
Adds an improved error message for server-side file validation errors.
The problem with this solution is that it just throws a generic error at the top of the form with no link/association to the input that caused the problem, as a normal validation error would do.
A future PR should attempt to address this shortfall.
BEGIN_COMMIT_OVERRIDE
fix: Adds improved server-side error handling for files.
END_COMMIT_OVERRIDE