fix: Updates the review page start title #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://lkcwkdpldnmciqmvcy4hfwfcmi0mseif.lambda-url.ca-central-1.on.aws/ |
timarney
reviewed
Oct 28, 2024
| const title = | ||
| reviewItem.id !== "start" | ||
| ? reviewItem.title | ||
| : t("start", { ns: "common", lng: language }); |
There was a problem hiding this comment.
I think we want
"logic": {
"start": "Start page",
timarney
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Updates review page start title to use the correct language. Previously a check was done on whether the group was undefined, that was the "flag" for whether it was a start group or not. The check was updated to look at the group Id instead.
Test
Load up a group form. Switch the language to French. The Review page Start group should now be in French (the remaining group titles should be unchanged).
EXPECTED
