fix: Add client side validation to public forms #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://n545fqpsm34is7sqhrj6y7uj7u0qmgdh.lambda-url.ca-central-1.on.aws/ |
|
Tested and seeing some activity is it what's expected? |
yes, that's unrelated. |
🧪 Review environmenthttps://er6my7ulm75nda5l2k3462jbde0hqkcz.lambda-url.ca-central-1.on.aws/ |
craigzour
previously approved these changes
Oct 31, 2024
bryan-robitaille
previously approved these changes
Oct 31, 2024
app/(gcforms)/[locale]/(support)/unlock-publishing/components/client/Success.tsx
Outdated
Show resolved
Hide resolved
dsamojlenko
dismissed stale reviews from bryan-robitaille and craigzour
via
5316e9f
craigzour
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Related: #4519
While investigating the recent memory leak issues, there seems to be some correlation to Contact form submissions with large amounts of invalid data.
Noted that this form (along with Support and Unlock publishing) rely exclusively on server-side validation of form inputs.
Given that Contact and Support are public-facing unauthenticated forms, it's good practice to validate both client-side and server-side. Catching validation errors client-side will prevent unnecessary round trips to the server.
Unclear if this is the specific cause of the memory leak issue, but given the correlation between Contact form submits and the recent spikes, it's a possibility to be considered, and as mentioned is just good practice.
Testing
This change affects the Contact, Support, and Unlock publishing form.
To test, visit the forms and submit some information.
The form should behave as normal.
To get a better sense of what's changed, open the Network tab of the Developer tools in Chrome.