General improvements for CI and project versioning #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Changelog:
poetry.lock
file for compatibility with newer versions ofpoetry
. Additionally, the lock version has been upgraded to2.0.0
.$PATH
, which will enable you to run themake test-local
command from the root folder of the project.snok/install-poetry
project appears to be better maintained and more active.Github Action changes
build
job by creating an additional, dependent job calledrelease
, which has steps that should only be executed when runningpush
against themaster
branch.$env.ACT
environment variable as one of the conditions for the release job, mainly as a way to prevent the local environment from running it.act
creates, as mentioned here, I used the solution provided by the following comment in order to fix this issue.v3.11.3
andv1.5.1
respectively) that are tested and confirmed working. Wildcards were removed wherever possible. I strongly recommend using an automated dependency management tool such asRenovate
.Pull Requests
code from being executed and released when running againstMaster
branches. This is not primarily a security feature, but rather a way to prevent the unintentional usage of the action to create releases when proposing changes.I recommend local testing of this PR both in a traditional Python3 virtual environment and using the Act-cli testing tool. Any feedback is more than welcome.