Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net Core/Net 5 - Enhancements #3388

Closed
5 tasks done
amaitland opened this issue Feb 3, 2021 · 1 comment
Closed
5 tasks done

Net Core/Net 5 - Enhancements #3388

amaitland opened this issue Feb 3, 2021 · 1 comment
Assignees
@amaitland
Milestone
89.0.x

Comments

@amaitland
Copy link
Member

amaitland commented Feb 3, 2021 •
edited
Loading

Follow up to #3197

There are a few things that I didn't quite get time for which should be done

  • Add WPF DPI Changed handler (Window.DpiChanged)
  • Implement .Net Core/Net 5 specific DependencyChecker
  • Add option to CefSharp.Common.NETCore.targets to disable the Otherwise block, when used in an AnyCPU class library the dependencies added will flow through to the generated Nuget package (using the default nuget pack option, not a problem if manual). (commit 5ebb08f)
    Potentially check $(OutputType) in MSBuild is class library and disable this behaviour by default with an override to enable
  • Update CefSharp.Common.NETCore to include chromiumembeddedframework.runtime as BuildTransitive so the .props files are usable as transitive reference. (commit 07ce2e0)
  • Add SourceLink to NetCore projects (currently .Net 4.5.2packages useGitLink`) (commit 5780aef)
@amaitland amaitland self-assigned this Feb 3, 2021
@amaitland amaitland mentioned this issue Feb 3, 2021
Closed
20 tasks
@amaitland amaitland added this to the 89.0.x milestone Mar 5, 2021
amaitland added a commit to amaitland/Chromely.CefSharp that referenced this issue Mar 5, 2021
@amaitland
Upgrade to CefSharp 88.2.90
fe0c3a6 
- Remove x86/x64 platforms from the solution
- Chromely.CefSharp.Integration.TestApp sets RuntimeIdentifier
- Change TargetFrameworks to net462;netcoreapp3.1;net5.0-windows

**KNOWN ISSUES**
- The generated Nuget package has exclude buildTransitive set which will likely break the package (not tested, though very likely)
  The CefSharp.Common.NETCore.targets included in the buildTransitive has a hack to support AnyCPU which adds package references
  directly to the chromiumembeddedframework.runtime.win-x64 and chromiumembeddedframework.runtime.win-x86 packages
  Will need to add some configuration options to CefSharp to disable this behaviour, I've added a task to cefsharp/CefSharp#3388
@amaitland amaitland mentioned this issue Mar 5, 2021
Merged
amaitland added a commit to amaitland/Chromely.CefSharp that referenced this issue Mar 5, 2021
@amaitland
Upgrade to CefSharp 88.2.90
09b9a12 
- Remove x86/x64 platforms from the solution
- Chromely.CefSharp.Integration.TestApp sets RuntimeIdentifier
- Change TargetFrameworks to net462;netcoreapp3.1;net5.0-windows

**KNOWN ISSUES**
- The generated Nuget package has exclude buildTransitive set which will likely break the package (not tested, though very likely)
  The CefSharp.Common.NETCore.targets included in the buildTransitive has a hack to support AnyCPU which adds package references
  directly to the chromiumembeddedframework.runtime.win-x64 and chromiumembeddedframework.runtime.win-x86 packages
  Will need to add some configuration options to CefSharp to disable this behaviour, I've added a task to cefsharp/CefSharp#3388
amaitland added a commit to amaitland/Chromely.CefSharp that referenced this issue Mar 5, 2021
@amaitland
Upgrade to CefSharp 88.2.90
df91e67 
- Remove x86/x64 platforms from the solution
- Chromely.CefSharp.Integration.TestApp sets RuntimeIdentifier
- Change TargetFrameworks to net462;netcoreapp3.1;net5.0-windows

**KNOWN ISSUES**
- The generated Nuget package has exclude buildTransitive set which will likely break the package (not tested, though very likely)
  The CefSharp.Common.NETCore.targets included in the buildTransitive has a hack to support AnyCPU which adds package references
  directly to the chromiumembeddedframework.runtime.win-x64 and chromiumembeddedframework.runtime.win-x86 packages
  Will need to add some configuration options to CefSharp to disable this behaviour, I've added a task to cefsharp/CefSharp#3388
amaitland added a commit that referenced this issue Mar 16, 2021
@amaitland
* WPF - Add OnDpiChanged for NetCore builds
e78e18f 
Automatically deals with DPI Change

Issue #3388
amaitland added a commit that referenced this issue Mar 16, 2021
@amaitland
WPF - Add OnDpiChanged for NetCore builds
207172e 
Automatically deals with DPI Change

Issue #3388
amaitland added a commit that referenced this issue Mar 23, 2021
@amaitland
Net Core - Add DependencyChecker.netcore
1011f72 
Specific .Net core DependencyChecker that takes care of the specifics of running under .Net Core/.Net 5.0
Later on the DependencyChecker can be unified.

Issue #3388
amaitland added a commit that referenced this issue Mar 23, 2021
@amaitland
Net Core - Add DependencyChecker.netcore
24056cd 
Specific .Net core DependencyChecker that takes care of the specifics of running under .Net Core/.Net 5.0
Later on the DependencyChecker can be unified.

Issue #3388
@amaitland amaitland reopened this Mar 25, 2021
@amaitland
Copy link
Member Author

amaitland commented Mar 25, 2021 •
edited
Loading

DependencyChecker for AnyCPU needs a tweak, for .Net Core 3.1/.Net 5.0 CefSharp.Core.Runtime.dll is in the lib folder and not the native folder.

https://github.com/cefsharp/CefSharp/blob/cefsharp/89/CefSharp/DependencyChecker.cs#L148

For .Net 4.x the location is correct. So a conditional check is required.

The MinimalExample dependency checking will be disabled temp until this is fixed in the final 89 release

amaitland added a commit that referenced this issue Mar 27, 2021
@amaitland
Net Core - DependencyChecker fix AnyCPU validation for CefSharp.Core.…
1692c1b 
…Runtime.dll

Resolves #3388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
None yet
Projects
None yet
Milestone
89.0.x
Development

No branches or pull requests
1 participant
@amaitland