Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget - Update targets to use <ContentWithTargetPath/> #2911

Closed
wants to merge 1 commit into from
Closed

Nuget - Update targets to use <ContentWithTargetPath/> #2911

wants to merge 1 commit into from

Conversation

GiantappMan
Copy link

@GiantappMan GiantappMan commented Sep 27, 2019

replace None with ContentWithTargetPath

Fixes #2456

Summary: [summary of the change and which issue is fixed here]

  • modify “None” to "ContentWithTargetPath" in nuget floder

Changes:

  • modify CefSharp.Common.targets
  • modify CefSharp.WinForms.targets
  • modify CefSharp.Wpf.targets
  • add winform/wpf .targets file to nuget folder

How Has This Been Tested?

Screenshots (if appropriate):

before change:
image
after change:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

replace None with ContentWithTargetPath
@AppVeyorBot
Copy link

Build CefSharp 76.1.90-CI3300 completed (commit d13ea928f8 by @DaZiYuan)

@amaitland
Copy link
Member

Please provide a reference that details <ContentWithTargetPath/>.

We still support VS2013/2015/2017, so any change needs to be backwards compatible.

The <None/> entries copy the files one level deep when referenced as a sub project (you can reference CefSharp in a dll and the relevant folders will be copied to your executable long as it's a direct reference). Please evaluate if this change in a breaking one in this context.

@amaitland amaitland changed the title fix #2456 Nuget - Update targets to use <ContentWithTargetPath/> Sep 27, 2019
@GiantappMan
Copy link
Author

image

vs2015 looks fine ,I don't have vs2013/17. I will be grateful if somebody can help this .

@amaitland
Copy link
Member

Without a clear understanding of ContentWithTargetPath, what versions it supports, does it include the resource in a ClickOnce installer like changing to <Content/> would I cannot proceed with this. Appreciate the effort though 👍

For me the safest option would be changing to <Content/> as outlined in #2456 (comment)

@amaitland
Copy link
Member

A new set of packages that better supports PackageReferene will be created see #2795 for details.

@amaitland amaitland closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide artifacts from VS Solution Explorer in new CsProj format
3 participants