Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Do not hardcode an out-of-date version of PyPy #715

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 16, 2024

PyPy v7.3.15 is now available:

    strategy:
      fail-fast: false
      matrix:
-       python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.10-v7.3.14']
+       python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.10']

Note: The Sphinx failures discussed below were fixed in:

@cclauss
Copy link
Contributor Author

cclauss commented Jan 16, 2024

Please rerun the failing Python 3.8 test which seems unrelated to this change.

  py38-django32: OK (96.52=setup[13.27]+cmd[0.36,82.89] seconds)
  py38-django41: OK (92.26=setup[9.50]+cmd[0.36,82.40] seconds)
  py38-django42: OK (92.26=setup[9.51]+cmd[0.36,82.39] seconds)
  apicheck: FAIL code 2 (20.36=setup[18.31]+cmd[2.05] seconds)
  linkcheck: FAIL code 2 (18.64=setup[16.54]+cmd[2.10] seconds)

@cclauss cclauss marked this pull request as ready for review January 16, 2024 10:09
@cclauss
Copy link
Contributor Author

cclauss commented Jan 17, 2024

I reran the failing tests with git commit --amend --no-edit && git push --force and got the same errors :-(

I am a bit baffled... The apicheck and linkcheck failures are about:

but I cannot find that text in this repo:
% git grep djangoproject

t/proj/settings.py:https://docs.djangoproject.com/en/1.9/topics/settings/
t/proj/settings.py:https://docs.djangoproject.com/en/1.9/ref/settings/
t/proj/settings.py:# See https://docs.djangoproject.com/en/1.9/howto/deployment/checklist/
t/proj/settings.py:# https://docs.djangoproject.com/en/1.9/ref/settings/#databases
t/proj/settings.py:# https://docs.djangoproject.com/en/1.9/ref/settings/#auth-password-validators
t/proj/settings.py:# https://docs.djangoproject.com/en/1.9/topics/i18n/
t/proj/settings.py:# https://docs.djangoproject.com/en/1.9/howto/static-files/
t/proj/wsgi.py:https://docs.djangoproject.com/en/1.9/howto/deployment/wsgi/

Running Sphinx v7.1.2
making output directory... done
loading intersphinx inventory from https://docs.python.org/dev/objects.inv...
loading intersphinx inventory from https://www.sphinx-doc.org/en/stable/objects.inv...
loading intersphinx inventory from https://celery.readthedocs.io/en/main/objects.inv...
loading intersphinx inventory from https://doc.djangoproject.com/en/dev/_objects...
loading intersphinx inventory from https://django-celery-results.readthedocs.io/en/latest/objects.inv...
intersphinx inventory has moved: https://www.sphinx-doc.org/en/stable/objects.inv -> https://www.sphinx-doc.org/en/master/objects.inv
intersphinx inventory has moved: https://celery.readthedocs.io/en/main/objects.inv -> https://docs.celeryq.dev/en/main/objects.inv

Warning, treated as error:
failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://doc.djangoproject.com/en/dev/_objects' not fetchable due to <class 'requests.exceptions.ConnectionError'>: HTTPSConnectionPool(host='doc.djangoproject.com', port=443): Max retries exceeded with url: /en/dev/_objects (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7f11746d8c40>: Failed to resolve 'doc.djangoproject.com' ([Errno -2] Name or service not known)"))

@cclauss
Copy link
Contributor Author

cclauss commented Jan 18, 2024

I believe that these two failures are caused by last week's hot patch celery/sphinx_celery#64 which points to https://doc.djangoproject.com/ (does not exist) instead of https://docs.djangoproject.com/ (exists).

@Nusnus
Copy link
Member

Nusnus commented Jan 18, 2024

I believe that these two failures are caused by last week's hot patch celery/sphinx_celery#64 which points to https://doc.djangoproject.com/ (does not exist) instead of https://docs.djangoproject.com/ (exists).

@Nusnus

Indeed, correct.
The problem is that the existing URL crashed the entire Celery doc build process.

That being said, I've upgraded Sphinx from v5.3.0 to 7.x.x yesterday, so let me see if it works with the other URL now.

I'll report here my conclusion.

@Nusnus
Copy link
Member

Nusnus commented Jan 18, 2024

Fixed merged to master.
Let me see how fast I can get a patch release for v2.1.2.
Probably in the next 12-24h.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 18, 2024

Merging to master seems to have fixed this PR. Thanks much!!

@Nusnus
Copy link
Member

Nusnus commented Jan 18, 2024

Merging to master seems to have fixed this PR. Thanks much!!

The fix was released: https://github.com/celery/sphinx_celery/releases/tag/v2.1.3

@auvipy auvipy merged commit 00f0a5c into celery:main Jan 18, 2024
9 checks passed
@cclauss cclauss deleted the patch-1 branch January 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants