-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add a github workflow to build and publish #749
Conversation
Hi 👋 After consideration, this change required some discussion:
|
I never had any report of not having any generation of wheel in the new releases I have been doing for years. Only 2.6 seems as an exception as I did not release it |
I believe that I did the v2.6 release so I might have not done all the right steps. It might be best for you to lead the v2.7 release @auvipy to verify the new process. We have enough updates... |
I will try to do so. thanks for doing lots of work in the mean time! might ping you If I feel not sure about something! |
@auvipy I know you are busy but the Django v5.1 release is scheduled on or around Wednesday. The current release on PyPI will downgrade user dependencies on Django v5.1:
as discussed in |
This failed to publish https://github.com/celery/django-celery-beat/releases/tag/v2.7.0 to PyPI at https://github.com/celery/django-celery-beat/actions/runs/10487732600/job/29048739728 with the message:
Also, we wanted wheels built and published in this release but v2.7.0 seems that have source code but no wheels. |
Hi @cclauss, As I mention in the PR's description, the publishing step required some configuration on the PyPI repo, to configure the workflow as a trusted publisher (see configuring-trusted-publishing). Can you tell me if this step has been carried out correctly? The wheels are therefore not published on the github release because the CI job was skipped due to the first error: |
On https://pypi.org/manage/account/publishing I can manage other GitHub projects but I am unable to manage |
We can do it manually as well |
@florianvazelle @cclauss |
OK, but... https://github.com/celery/django-celery-beat/actions/runs/10487732600 released to PyPI (Yeah!) but failed to Upload to GitHub Release. I think we are OK because the Upload to GitHub Release error message was:
The remaining problem is that the release contains no wheels. |
%
Even though I cannot find a wheel in the release artifacts, somehow one is created. |
Hi 👋
I submit a PR to build & publish the wheel in CI.
I don't know why, but no wheel is released on PyPI for the 2.6.0 version of
django-celery-beat
. So accordingly to the pypa example: Publishing package distribution releases using GitHub Actions CI/CD workflows, I add a workflow that automatically:pull_request
, themain
branch and tags,