Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add temp index #58

Merged
merged 3 commits into from
Feb 13, 2024
Merged

feat: add temp index #58

merged 3 commits into from
Feb 13, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jan 30, 2024

Overview

This adds a temporary index, as a placeholder for #57 as it is a WIP.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

jcstein
jcstein commented Jan 30, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jcstein jcstein requested a review from YazzyYaz January 30, 2024 02:47
ebuchman
ebuchman approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We're a bit inconsistent in author alias vs email but not worth nit picking since we'll want to automate populating this

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member Author

jcstein commented Feb 8, 2024

We're a bit inconsistent in author alias vs email but not worth nit picking since we'll want to automate populating this

I think that CIP-1 states this is the correct practice?

@jcstein
Copy link
Member Author

jcstein commented Feb 8, 2024

Regardless, agreed. I would like to automate this out of being done manually.

@jcstein jcstein self-assigned this Feb 8, 2024
@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 8, 2024
@jcstein jcstein merged commit 972a314 into main Feb 13, 2024
1 check passed
@jcstein jcstein deleted the jcs/add-temp-index branch February 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@YazzyYaz YazzyYaz Awaiting requested review from YazzyYaz

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcstein @ebuchman