Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run interchain tests via CI #3358

Closed
rootulp opened this issue Apr 19, 2024 · 0 comments · Fixed by #3643
Closed

Run interchain tests via CI #3358

rootulp opened this issue Apr 19, 2024 · 0 comments · Fixed by #3643
Assignees
@rootulp
Labels
CI item that directly relates to or modify the CI testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Apr 19, 2024

Context

#3308 introduced tests that use interchaintest to test IBC related features

Problems

The tests aren't run in CI

Proposal

Add a Github workflow to run make test-interchain in CI. The test needs to be updated so that it runs on a celestia-app Docker image that is built from the contents of a PR. In other words, we'll need to update

https://github.com/celestiaorg/celestia-app/pull/3308/files#diff-1339fcbad26587fb3903d7f25f995a05e62e8f2c32fffaf43cffa836e25f78bfR16

to refer to the PR number that CI is running against.
@rootulp rootulp added testing items that are strictly related to adding or extending test coverage CI item that directly relates to or modify the CI labels Apr 19, 2024
@rootulp rootulp mentioned this issue Apr 19, 2024
Merged
@rootulp rootulp mentioned this issue Jun 14, 2024
Closed
1 task
@rootulp rootulp self-assigned this Jun 20, 2024
This was referenced Jun 27, 2024
Merged
Merged
rootulp added a commit that referenced this issue Jul 1, 2024
@rootulp @cmwaters
ci: run make test-interchain in CI (#3643)
7ee7290 
Closes #3358

## Testing

Passes locally and in CI

---------

Co-authored-by: Callum Waters <[email protected]>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp @cmwaters
ci: run make test-interchain in CI (#3643)
1c38c3d 
Closes celestiaorg/celestia-app#3358

## Testing

Passes locally and in CI

---------

Co-authored-by: Callum Waters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
CI item that directly relates to or modify the CI testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run make test-interchain in CI rootulp/celestia-app
1 participant
@rootulp