-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchestrator old signatures replay #351
Orchestrator old signatures replay #351
Conversation
# Conflicts: # x/qgb/types/query.pb.go
This one is ready for review also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having to resort to things like this is not ideal, and rather messy imho, but I understand why and we should be able to clean up most of this using the worker pool model later
Co-authored-by: Evan Forbes <[email protected]>
Codecov Report
@@ Coverage Diff @@
## qgb-integration #351 +/- ##
==================================================
Coverage ? 11.82%
==================================================
Files ? 55
Lines ? 11071
Branches ? 0
==================================================
Hits ? 1309
Misses ? 9672
Partials ? 90 Continue to review full report at Codecov.
|
Co-authored-by: John Adler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but will defer to @evan-forbes
Co-authored-by: John Adler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had one minor nit left, but pre aproving
lgtm 👍
* adds valset request by nonce * add querier, broadcaster and updates orchestrator to use them * partially fix the tests for the new design * update the deployer for the new design * update orchestrator to new design * Adds querier and evm client update * update relayer to new design * fix query.proto * update deploy_command to use new Querier * formatting * formatting * go.sum * adds query last unbonding height * adds orchestrator valset replay * adds orchestrator data commitment replay * cosmetics * puts valset signature catchup in a separate function * puts data commitment signature catchup in a separate function * Querier cosmetics * go.sum * rename querier and catchup functions * adds genesis case to querylastvalset * format + todo * initialized tm logger in test * update orchestrator code to use uint64 instead of int64 * better logging * Update x/qgb/orchestrator/orchestrator_client.go Co-authored-by: Evan Forbes <[email protected]> * formats import * rename addOldValsetAttestations and addOldDataCommitmentAttestations * defering logging instead of repeating it on every return * adds comment * Update x/qgb/orchestrator/relayer.go Co-authored-by: John Adler <[email protected]> * Update x/qgb/orchestrator/querier.go Co-authored-by: John Adler <[email protected]> * remove unnecessary error Co-authored-by: Evan Forbes <[email protected]> Co-authored-by: John Adler <[email protected]>
Add valsets/Data commitment orchestrator signature replay.
Closes: #337 #336