Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log v2 upgrade #3628

Merged
merged 2 commits into from
Jun 27, 2024
Merged

chore: log v2 upgrade #3628

merged 2 commits into from
Jun 27, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 26, 2024

Closes #3627

Testing

Confirmed the log shows up during an upgrade

4:29PM INF upgrading from app version 1 to 2
4:29PM INF executed block height=2 module=state num_invalid_txs=0 num_valid_txs=0
4:29PM INF adding a new module: interchainaccounts
4:29PM INF created new capability module=ibc name=ports/icahost
4:29PM INF port binded module=x/ibc/port port=icahost
4:29PM INF claimed capability capability=2 module=icahost name=ports/icahost
4:29PM INF adding a new module: minfee
4:29PM INF adding a new module: packetfowardmiddleware
4:29PM INF adding a new module: signal

@rootulp rootulp self-assigned this Jun 26, 2024
@rootulp rootulp requested a review from a team as a code owner June 26, 2024 20:31
@rootulp rootulp requested review from staheri14 and ninabarbakadze and removed request for a team June 26, 2024 20:31
Copy link
Contributor

coderabbitai bot commented Jun 26, 2024

Warning

Rate limit exceeded

@rootulp has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 44 minutes and 57 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9475c4b and 1a8692c.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested review from cmwaters and removed request for staheri14 June 26, 2024 20:31
@celestia-bot celestia-bot requested a review from a team June 26, 2024 20:32
@rootulp rootulp enabled auto-merge (squash) June 26, 2024 20:32
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a log at the end when the upgrade has been completed or people just wait for the next block to be produced

@rootulp rootulp merged commit 487648e into celestiaorg:main Jun 27, 2024
32 checks passed
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 27, 2024

Do we want a log at the end when the upgrade has been completed or people just wait for the next block to be produced

Hmm good point. We can add a log in BeginBlock so that it shows up when the next block is produced.

@rootulp rootulp deleted the rp/log-v2-upgrade branch June 27, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a log statement for v1 -> v2 upgrade
3 participants