Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds last valset request before height query #365

Merged
merged 6 commits into from
Apr 28, 2022
Merged

adds last valset request before height query #365

merged 6 commits into from
Apr 28, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 28, 2022

Closes #364

@rach-id rach-id added the C: QGB label Apr 28, 2022
@rach-id rach-id self-assigned this Apr 28, 2022
@rach-id rach-id linked an issue Apr 28, 2022 that may be closed by this pull request
Add QGB last valset before height query #364
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (qgb-integration@4fe09dc). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #365   +/-   ##
==================================================
  Coverage                   ?   11.97%           
==================================================
  Files                      ?       55           
  Lines                      ?    10931           
  Branches                   ?        0           
==================================================
  Hits                       ?     1309           
  Misses                     ?     9532           
  Partials                   ?       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe09dc...d37e8f6. Read the comment docs.

adlerjohn
adlerjohn reviewed Apr 28, 2022
View reviewed changes
x/qgb/keeper/query_valset.go Outdated Show resolved Hide resolved
x/qgb/keeper/query_valset.go Show resolved Hide resolved
x/qgb/keeper/query_valset.go Show resolved Hide resolved
@rach-id rach-id merged commit 0e5db96 into celestiaorg:qgb-integration Apr 28, 2022
@rach-id rach-id deleted the add_previous_valset_query_by_height branch April 28, 2022 16:14
rach-id added a commit to rach-id/celestia-app that referenced this pull request May 9, 2022
@rach-id @adlerjohn
adds last valset request before height query (celestiaorg#365)
20ce810 
* adds last valset request before  height query

* regenerating correct query.pb.go

* adds check before querying next valset

* Update x/qgb/keeper/query_valset.go

Co-authored-by: John Adler <[email protected]>

* adds comment

Co-authored-by: John Adler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes evan-forbes is a code owner

Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add QGB last valset before height query
4 participants
@rach-id @codecov-commenter @adlerjohn @evan-forbes