Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to cosmos-sdk v1.24.0-sdk-v0.46.16 #3725

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 23, 2024

@rootulp rootulp added backport:v1.x PR will be backported automatically to the v1.x branch upon merging backport:v2.x PR will be backported automatically to the v2.x branch upon merging labels Jul 23, 2024
@rootulp rootulp self-assigned this Jul 23, 2024
@rootulp rootulp requested a review from a team as a code owner July 23, 2024 20:17
@rootulp rootulp requested review from evan-forbes and ninabarbakadze and removed request for a team July 23, 2024 20:17
Copy link
Contributor

coderabbitai bot commented Jul 23, 2024

Walkthrough

Walkthrough

The changes primarily involve updating the version of the github.com/cosmos/cosmos-sdk dependency in two go.mod files, moving from version v1.23.0-sdk-v0.46.16 to v1.24.0-sdk-v0.46.16. This upgrade aims to leverage new features, bug fixes, and performance improvements in the Cosmos SDK. While no alterations were made to exported or public entity declarations, the update could potentially influence the application's functionality due to changes within the SDK.

Changes

Files Change Summary
go.mod, test/interchain/go.mod Updated github.com/cosmos/cosmos-sdk from v1.23.0-sdk-v0.46.16 to v1.24.0-sdk-v0.46.16. No changes to exported or public entities.

Sequence Diagram(s)

sequenceDiagram
    participant A as Application
    participant B as Cosmos SDK
    A->>B: Use Cosmos SDK v1.23.0-sdk-v0.46.16
    B-->>A: Return functionality
    A->>B: Update to Cosmos SDK v1.24.0-sdk-v0.46.16
    B-->>A: Return new functionality
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celestia-bot celestia-bot requested a review from a team July 23, 2024 20:17
@rootulp rootulp enabled auto-merge (squash) July 23, 2024 20:18
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gather this will land in v3 right?

edit: ah I assume if it just fixes the export function that we will roll them out to minor releases

@rootulp rootulp merged commit 85bf2ae into celestiaorg:main Jul 24, 2024
34 checks passed
mergify bot pushed a commit that referenced this pull request Jul 24, 2024
Upgrade to
https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.24.0-sdk-v0.46.16

(cherry picked from commit 85bf2ae)

# Conflicts:
#	go.sum
#	test/interchain/go.mod
#	test/interchain/go.sum
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 24, 2024

yep exactly! I think it is safe to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging backport:v2.x PR will be backported automatically to the v2.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants