Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary config.Seal() (backport #3786) #3801

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 20, 2024

- Add unit tests to cosmos SDK config set up
- Remove an unnecessary `config.Seal` invocation that has been around
for a [long
time](5e4a1dc#diff-9e0425d31b7cf4072a746feb0c6bc1e0045b639e01dd0b5ac2f08e8c2952c886R120)
but isn't necessary because the `init()` command always sets and seals
the config.

(cherry picked from commit 9c9e77a)

# Conflicts:
#	cmd/celestia-appd/cmd/root.go
@mergify mergify bot added the conflicts label Aug 20, 2024
@mergify mergify bot requested a review from a team as a code owner August 20, 2024 18:33
@mergify mergify bot requested a review from rootulp August 20, 2024 18:33
Copy link
Contributor Author

mergify bot commented Aug 20, 2024

Cherry-pick of 9c9e77a has failed:

On branch mergify/bp/v2.x/pr-3786
Your branch is up to date with 'origin/v2.x'.

You are currently cherry-picking commit 9c9e77a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    app/config.go
	new file:   app/sdk_config.go
	new file:   app/sdk_config_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cmd/celestia-appd/cmd/root.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from ninabarbakadze August 20, 2024 18:33
@github-actions github-actions bot added the bot item was created by a bot label Aug 20, 2024
@rootulp rootulp self-assigned this Aug 20, 2024
@rootulp rootulp marked this pull request as draft August 20, 2024 18:55
@rootulp rootulp marked this pull request as ready for review August 20, 2024 18:57
@rootulp rootulp enabled auto-merge (squash) August 20, 2024 18:58
@rootulp rootulp merged commit 3a2633a into v2.x Aug 20, 2024
29 of 32 checks passed
@rootulp rootulp deleted the mergify/bp/v2.x/pr-3786 branch August 20, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants