ci: use goreleaser-cross for goreleaser-check command (backport #3806) #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #3805 [goreleaser v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0) deprecated the `name_template` field in favor of `version_template`. Our goreleaser-check command used a GH action that was using goreleaser v2.2.0 so we fixed the deprecation in #3797 but the make prebuilt-binary command uses goreleaser-cross which was using a previous version of goreleaser that fails for the new field. This PR updates the goreleaser-check command to use the goreleaser-cross Docker image so that the check command and prebuilt-binary command uses the same version. Note: we'll need to update `name_template` to `version_template` when we upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which bumped to goreleaser 2.22.0. See goreleaser/goreleaser-cross#77 (cherry picked from commit 13f3098)
rootulp
approved these changes
Aug 22, 2024
cmwaters
approved these changes
Aug 22, 2024
ninabarbakadze
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3805
goreleaser v2.2.0 deprecated the
name_templatefield in favor ofversion_template. Our goreleaser-check command used a GH action that was using goreleaser v2.2.0 so we fixed the deprecation in #3797 but the make prebuilt-binary command uses goreleaser-cross which was using a previous version of goreleaser that fails for the new field.This PR updates the goreleaser-check command to use the goreleaser-cross Docker image so that the check command and prebuilt-binary command uses the same version.
Note: we'll need to update
name_templatetoversion_templatewhen we upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which bumped to goreleaser 2.22.0. See goreleaser/goreleaser-cross#77This is an automatic backport of pull request #3806 done by Mergify.