Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/ipfs/go-bitswap from 0.8.0 to 0.9.0 #1043

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2022

Bumps github.com/ipfs/go-bitswap from 0.8.0 to 0.9.0.

Release notes

Sourced from github.com/ipfs/go-bitswap's releases.

v0.9.0

Overview

This release splits the Bitswap implementation into standalone client and server implementations.

This preserves backwards compatibility with bitswap.New() returning an exchange.Interface implementation that uses the client and server.

What's Changed

Full Changelog: ipfs/go-bitswap@v0.8.0...v0.9.0

Commits
  • 4e3736a chore: release v0.9.0
  • 5b013e0 Merge pull request #570 from Jorropo/split
  • b8fd335 fix: message queue test races on Windows
  • ab72e8e fix: plumb through ctor contexts to preserve metrics scopes
  • 81393bc refactor: remove metrics object and other review changes
  • 1ac4824 test: remove TestTracer
  • 696d69d refactor: remove the need of generics
  • 8a75bc2 refactor: split client and server and all sideeffects that this incurs
  • 969c5da chore: remove GX
  • 4fcd291 chore: remove goprocess from blockstoremanager
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the kind:deps Pull requests that update a dependency file label Aug 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #1043 (7cc7f45) into main (ab0bdbc) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   57.62%   57.36%   -0.27%     
==========================================
  Files         133      133              
  Lines        8307     8307              
==========================================
- Hits         4787     4765      -22     
- Misses       3047     3069      +22     
  Partials      473      473              
Impacted Files Coverage Δ
ipld/get_shares.go 90.00% <0.00%> (-10.00%) ⬇️
fraud/pb/proof.pb.go 29.22% <0.00%> (-4.29%) ⬇️
fraud/bad_encoding.go 63.00% <0.00%> (-3.00%) ⬇️
header/core/listener.go 58.49% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Bumps [github.com/ipfs/go-bitswap](https://github.com/ipfs/go-bitswap) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/ipfs/go-bitswap/releases)
- [Commits](ipfs/go-bitswap@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: github.com/ipfs/go-bitswap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/ipfs/go-bitswap-0.9.0 branch from 0a29c11 to 7cc7f45 Compare August 29, 2022 13:15
@Wondertan
Copy link
Member

Will be resolved with #1029

@Wondertan
Copy link
Member

But also requires some additional investigations around flakiness it introduces

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me
defer to @Wondertan

@Wondertan
Copy link
Member

@renaynay, it introduces various flakiness and we reverted the update previously

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2022

Superseded by #1054.

@dependabot dependabot bot closed this Sep 5, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/ipfs/go-bitswap-0.9.0 branch September 5, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants