chore!: prepare process proposal state #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
approved these changes
Jun 12, 2023
Codecov Report
@@ Coverage Diff @@
## evan/bump-upstream-v0.46.13 #326 +/- ##
===============================================================
- Coverage 65.52% 65.51% -0.01%
===============================================================
Files 666 666
Lines 71263 71271 +8
===============================================================
+ Hits 46693 46695 +2
- Misses 21976 21982 +6
Partials 2594 2594
|
evan-forbes
commented
Jun 12, 2023
rootulp
approved these changes
Jun 13, 2023
…com/celestiaorg/cosmos-sdk into evan/prepare-process-proposal-state
Base automatically changed from
evan/bump-upstream-v0.46.13
to
release/v0.46.x-celestia
June 13, 2023 13:24
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cosmos#15683 and cosmos#15717 are included in v0.46.13, which force us to stop relying on a query context for a specific height since errors are now thrown if there is no matching height in the store.
This PR is adds a simplified, but identical, approach to loading a branch of the state for prepare and process proposal as v0.47.x. This approach doesn't rely on height, instead it just creates a branch from the lastest commit multistore.
NOTE: in our version of
PrepareProposalwe don't pass height or chain-id, both of which are requried for basic signature verification. For this approach to work, we need to be sure to not pass a completely empty header when creating the proposal context. It must at least contain a height (anything greater than zero will work tbh) and chain-id. This PR also add a mechanism that provides access to the chain-id so we can do just that.Closes: #325
blocked by #324