Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check the namespace ID range of the leafHash in an absence proof to ensure soundness #116

Merged
merged 3 commits into from
Mar 3, 2023
Merged

feat: check the namespace ID range of the leafHash in an absence proof to ensure soundness #116

merged 3 commits into from
Mar 3, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Mar 1, 2023 •
edited
Loading

Overview

Addresses the issue set out in #115.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 changed the title feat: check leaf hash namespace range against queried namespace ID feat: check the namespace ID range of the leafHash in an absence proof to ensure soundness Mar 1, 2023
@staheri14 staheri14 marked this pull request as ready for review March 1, 2023 00:03
@staheri14 staheri14 self-assigned this Mar 1, 2023
@staheri14 staheri14 added the enhancement New feature or request label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #116 (81aa8ed) into master (4276d17) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   96.31%   96.33%   +0.02%     
==========================================
  Files           6        6              
  Lines         461      464       +3     
==========================================
+ Hits          444      447       +3     
  Misses         11       11              
  Partials        6        6
Impacted Files Coverage Δ
proof.go 96.84% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@staheri14 staheri14 marked this pull request as draft March 1, 2023 00:09
@staheri14 staheri14 marked this pull request as ready for review March 1, 2023 20:16
@staheri14 staheri14 requested review from rootulp, evan-forbes and liamsi and removed request for rootulp and evan-forbes March 1, 2023 20:18
rootulp
rootulp reviewed Mar 1, 2023
View reviewed changes
spec/nmt.md Show resolved Hide resolved
proof.go Show resolved Hide resolved
evan-forbes
evan-forbes approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@staheri14 staheri14 merged commit eec4bc0 into master Mar 3, 2023
@staheri14 staheri14 deleted the verify-leaf-hash-namespace-range branch March 3, 2023 19:35
This was referenced Mar 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rootulp rootulp rootulp approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@staheri14 staheri14

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staheri14 @rootulp @evan-forbes