Add HexString method for namespace id

[walldiss]

Overview

Implements #200

[codecov]

Codecov Report

Merging #201 (54ce402) into master (ba0ebb8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   95.39%   95.40%           
=======================================
  Files           5        5           
  Lines         565      566    +1     
=======================================
+ Hits          539      540    +1     
  Misses         15       15           
  Partials       11       11           

Impacted Files	Coverage Δ
namespace/id.go	100.00% <100.00%> (ø)

[evan-forbes]

oooh nice!

this might actually be more useful in https://github.com/celestiaorg/celestia-app/blob/578c71cbfe033c1b597b903d22fda06f772db816/pkg/namespace/namespace.go#L8

since I think this namespace doesn't include the namespace verison, correct @rootulp? which could lead to devs using the incorrect hex

[rootulp]

This namespace does include the namespace version so I think we can include this change here.

[Wondertan]

Any reason not to change the default behavior of String to be always hex encoded? The current String is sorta useless while having default human-readable support for Stringer everywhere is not, AFAICS. The current String implementation can still be done with string(ID) if anyone needs raw nid in string format.

@evan-forbes, @rootulp, thoughts?

[rootulp]

My rationale for recommending a new HexString() method is to avoid breaking compatability

changing existing String() method (would break compatibility)

If we can verify that no consumers of this library rely on the existing string representation then I think we can make the breaking change and modify the existing String() method

[staheri14]

LGTM!

[staheri14]

@walldiss Could you please revise the title of the PR to capitalize HexString? otherwise, it might be misleading, suggesting that the introduced method is private.

[Wondertan]

If we can verify that no consumers of this library rely on the existing string representation then I think we can make the breaking change and modify the existing String() method

I verified the usage in the node and it's used only in places where human-readable string is expected.

[evan-forbes]

I'm fine with mergin either, but I tend to agree that returning hex makes a lot of sense. if we need a string() for some reason, we can just call string(id)

[rootulp]

Merging b/c @walldiss doesn't have permission to.