Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.18 #62

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Update to Go 1.18 #62

merged 1 commit into from
Jul 31, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 25, 2022

Resolves #61

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #62 (da6a84e) into master (e679661) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files           7        7           
  Lines         364      364           
=======================================
  Hits          348      348           
  Misses         11       11           
  Partials        5        5

Help us with your feedback. Take ten seconds to tell us how you rate us.

rootulp
rootulp commented Jul 25, 2022
View reviewed changes
README.md
@@ -102,5 +104,3 @@ and was heavily inspired by the initial implementation in the celestiaorg [proto
[NebulousLabs']: https://gitlab.com/NebulousLabs/merkletree
[trillian]: https://github.com/google/trillian
[`LogHasher`]: https://github.com/google/trillian/blob/7502e99bb92ecf0ec8add958889c751f2cfc7f59/merkle/hashers/tree_hasher.go#L23-L34


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all whitespace / newline changes in this file were performed automatically by my editor due to markdownlint

@rootulp rootulp marked this pull request as ready for review July 25, 2022 21:08
evan-forbes
evan-forbes approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 41cb2b4 into celestiaorg:master Jul 31, 2022
@rootulp rootulp deleted the rp/go-1-18 branch July 31, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Go 1.18
4 participants
@rootulp @adlerjohn @evan-forbes @liamsi