Remove dependency on nebulous in proof generation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 95.54% 98.70% +3.15%
==========================================
Files 7 6 -1
Lines 382 386 +4
==========================================
+ Hits 365 381 +16
+ Misses 12 3 -9
+ Partials 5 2 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
reviewed
Sep 14, 2022
liamsi
requested changes
Sep 14, 2022
There was a problem hiding this comment.
Agree with @evan-forbes we should delete the internal package entirely.
liamsi
reviewed
Sep 14, 2022
rahulghangas
requested review from
liamsi and
evan-forbes
and removed request for
liamsi and
evan-forbes
|
Whoops, keep on forgetting you can only request one review. Sorry |
rahulghangas
force-pushed
the
feat/remove-nebulous-prove
branch
from
dfbe254
to
e667319
Compare
|
Poking @liamsi for re-review since changes requested. |
adlerjohn
reviewed
Sep 16, 2022
Co-authored-by: John Adler <[email protected]>
|
@liamsi please re-review |
|
bulld is failing due to codecov upload failure |
|
Poking @liamsi for re-review since changes requested. |
|
@liamsi bump |
liamsi
approved these changes
Oct 6, 2022
|
Sorry for the delay on my end. All requested changes were addressed. This is good to go! |
|
@adlerjohn can be merged now? |
adlerjohn
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same recursive approach as in nmt.Root() to generate proof
Removes the dependency on Celestiaorg/merkletree in proof generation