Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve namespace doc #81

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 25, 2022

  • Link to types
  • Remove IntervalDigest because it doesn't exist in this package

Screenshot

Screen Shot 2022-10-25 at 10 40 22 AM

- Link to types
- Remove IntervalDigest because it doesn't exist in this package
@rootulp rootulp added the documentation Improvements or additions to documentation label Oct 25, 2022
@rootulp rootulp self-assigned this Oct 25, 2022
@rootulp rootulp enabled auto-merge (squash) October 25, 2022 08:43
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #81 (0fb0698) into master (e679661) will increase coverage by 3.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   95.60%   98.70%   +3.10%     
==========================================
  Files           7        6       -1     
  Lines         364      386      +22     
==========================================
+ Hits          348      381      +33     
+ Misses         11        3       -8     
+ Partials        5        2       -3     
Impacted Files Coverage Δ
proof.go 96.51% <0.00%> (-0.55%) ⬇️
hasher.go 100.00% <0.00%> (ø)
internal/subtree_hasher.go
nmt.go 98.80% <0.00%> (+5.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rahulghangas rahulghangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 25, 2022

Thanks for reviewing so quickly @rahulghangas ! Sorry for tagging you, I just realized your review doesn't satisfy this constraint so adding @evan-forbes as a reviewer

Screen Shot 2022-10-25 at 11 42 53 AM

@rootulp rootulp merged commit 53eee18 into celestiaorg:master Oct 25, 2022
@rootulp rootulp deleted the rp/namespace-doc branch October 25, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants