Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanction tag to read contract controllers + templates #983

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

rkachowski
Copy link

@rkachowski rkachowski commented Oct 18, 2023

Description

JS is broken on read contract + proxy pages due to the #sanctions element not existing. This PR adds the data + element to relevant controllers and templates.

See https://explorer.celo.org/mainnet/token/0x471EcE3750Da237f93B8E339c536989b8978a438/read-proxy for an example

Tested

  • Tested locally against rc1staging database
  • before
image * after image

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Unit Test Results

       6 files  ±0     366 suites  ±0   3m 38s ⏱️ -28s
2 641 tests ±0  2 567 ✔️ ±0  74 💤 ±0  0 ±0 
2 655 runs  ±0  2 579 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit cbd99a4. ± Comparison against base commit 732db76.

♻️ This comment has been updated with latest results.

@rkachowski rkachowski marked this pull request as ready for review October 18, 2023 13:28
@rkachowski rkachowski requested a review from a team as a code owner October 18, 2023 13:28
@rkachowski rkachowski enabled auto-merge (squash) October 18, 2023 13:28
@rkachowski rkachowski merged commit 4c4f1b1 into master Oct 18, 2023
23 checks passed
@rkachowski rkachowski deleted the dhutch/fix-contract-read branch October 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants