fix setEpochDuration bug; ++ event

celo-org · Sep 24, 2024 · 4e4decf · 4e4decf
1 parent 1b37ffd
commit 4e4decf
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/packages/protocol/contracts-0.8/common/EpochManager.sol b/packages/protocol/contracts-0.8/common/EpochManager.sol
@@ -76,6 +76,7 @@ contract EpochManager is
    * @param epochNumber The epoch number that is finished being processed.
    */
   event EpochProcessingEnded(uint256 indexed epochNumber);
+  event EpochDurationSet(uint256 indexed newEpochDuration);
 
   /**
    * @notice Emitted when an epoch payment is sent.
@@ -367,7 +368,9 @@ contract EpochManager is
    * @dev Can only be set by owner.
    */
   function setEpochDuration(uint256 newEpochDuration) public onlyOwner {
+    require(!isOnEpochProcess(), "Cannot change epoch duration during processing.");
     epochDuration = newEpochDuration;
+    emit EpochDurationSet(newEpochDuration);
   }
 
   function isTimeForNextEpoch() public view returns (bool) {

diff --git a/packages/protocol/test-sol/unit/common/EpochManager.t.sol b/packages/protocol/test-sol/unit/common/EpochManager.t.sol
@@ -62,6 +62,7 @@ contract EpochManagerTest is Test, TestConstants, Utils08 {
   );
 
   event EpochProcessingStarted(uint256 indexed epochNumber);
+  event EpochDurationSet(uint256 indexed newEpochDuration);
 
   function setUp() public virtual {
     epochManager = new EpochManager_WithMocks();
@@ -245,6 +246,30 @@ contract EpochManagerTest_startNextEpochProcess is EpochManagerTest {
     assertEq(reserveBalanceAfter, reserveBalanceBefore + 4);
   }
 }
+contract EpochManagerTest_setEpochDuration is EpochManagerTest {
+  uint256 newEpochDuration = 5 * DAY;
+
+  function test_setsNewEpochDuration() public {
+    initializeEpochManagerSystem();
+    epochManager.setEpochDuration(newEpochDuration);
+    assertEq(epochManager.epochDuration(), newEpochDuration);
+  }
+
+  function test_Emits_EpochDurationSetEvent() public {
+    initializeEpochManagerSystem();
+
+    vm.expectEmit(true, true, true, true);
+    emit EpochDurationSet(newEpochDuration);
+    epochManager.setEpochDuration(newEpochDuration);
+  }
+
+  function test_Reverts_WhenIsOnEpochProcess() public {
+    initializeEpochManagerSystem();
+    epochManager.startNextEpochProcess();
+    vm.expectRevert("Cannot change epoch duration during processing.");
+    epochManager.setEpochDuration(newEpochDuration);
+  }
+}
 
 contract EpochManagerTest_sendValidatorPayment is EpochManagerTest {
   address group = actor("group");