++ missing onlyL1 check in downtime & double signing slasher

celo-org · Sep 24, 2024 · 968c62f · 968c62f
1 parent 580bd9d
commit 968c62f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/protocol/contracts/governance/DoubleSigningSlasher.sol b/packages/protocol/contracts/governance/DoubleSigningSlasher.sol
@@ -116,7 +116,7 @@ contract DoubleSigningSlasher is ICeloVersionedContract, SlasherUtil {
     uint256 index,
     bytes memory headerA,
     bytes memory headerB
-  ) public view returns (uint256) {
+  ) public view onlyL1 returns (uint256) {
     require(hashHeader(headerA) != hashHeader(headerB), "Block hashes have to be different");
     uint256 blockNumber = getBlockNumberFromHeader(headerA);
     require(

diff --git a/packages/protocol/contracts/governance/DowntimeSlasher.sol b/packages/protocol/contracts/governance/DowntimeSlasher.sol
@@ -170,7 +170,7 @@ contract DowntimeSlasher is ICeloVersionedContract, SlasherUtil {
   function getBitmapForInterval(
     uint256 startBlock,
     uint256 endBlock
-  ) public view returns (bytes32) {
+  ) public view onlyL1 returns (bytes32) {
     require(endBlock >= startBlock, "endBlock must be greater or equal than startBlock");
     // The signature bitmap for block N is stored in block N+1.
     // The latest block is `block.number - 1`, which stores the signature bitmap for
@@ -215,7 +215,7 @@ contract DowntimeSlasher is ICeloVersionedContract, SlasherUtil {
     uint256 startBlock,
     uint256 endBlock,
     uint256 signerIndex
-  ) public view returns (bool) {
+  ) public view onlyL1 returns (bool) {
     require(signerIndex < numberValidatorsInSet(startBlock), "bad validator index at start block");
     require(
       isBitmapSetForInterval(startBlock, endBlock),
@@ -250,7 +250,7 @@ contract DowntimeSlasher is ICeloVersionedContract, SlasherUtil {
     uint256[] memory startBlocks,
     uint256[] memory endBlocks,
     uint256[] memory signerIndices
-  ) public view returns (bool) {
+  ) public view onlyL1 returns (bool) {
     require(startBlocks.length > 0, "requires at least one interval");
     require(
       startBlocks.length == endBlocks.length,