Update monorepo to node 18

.circleci/config.yml

@@ -3,7 +3,6 @@
 
 version: 2.1
 
-
 parameters:
   # When you need to force a rebuild of the node modules cache then bump this version
   node-modules-cache-version:
@@ -28,7 +27,7 @@ reference:
 defaults: &defaults
   working_directory: ~/app
   docker:
-    - image: us.gcr.io/celo-testnet/circleci-node12:1.1.0
+    - image: us.gcr.io/celo-testnet/circleci-node18:1.0.0
   environment:
     # To avoid ENOMEM problem when running node
     NODE_OPTIONS: '--max-old-space-size=4096'
@@ -41,7 +40,7 @@ contract-defaults: &contract-defaults
 e2e-defaults: &e2e-defaults
   <<: *defaults
   docker:
-    - image: us-west1-docker.pkg.dev/devopsre/celo-monorepo/circleci-geth:latest
+    - image: us-west1-docker.pkg.dev/devopsre/clabs-public-images/circleci:node18.14-go1.16
   environment:
     CELO_BLOCKCHAIN_BRANCH_TO_TEST: release/1.7.x
 general:
@@ -78,6 +77,9 @@ commands:
       - run:
           name: Install dependencies
           command: |
+            # node-gyp needs to know where python is at when installed
+            yarn config set python $(which python3)
+
             if [ ! -e ~/.tmp/yarn_deps_have_changed ]; then
               # Though `yarn install` is instantaneous with up-to-date node_modules which is the case when we've restored cached node_modules,
               # there's currently a bug with the generated node_modules/.yarn-integrity file which is apparently not entirely stable
@@ -91,7 +93,6 @@ commands:
               yarn run postinstall
               exit 0
             fi
-
             # Deals with yarn install flakiness which can come due to yarnpkg.com being
             # unreliable. For example, https://circleci.com/gh/celo-org/celo-monorepo/82685
             yarn install || yarn install || yarn install
@@ -128,7 +129,6 @@ jobs:
     # Source: https://circleci.com/docs/2.0/configuration-reference/#resource_class
     resource_class: large
     steps:
-
       - restore_cache:
           keys:
             - source-v1-{{ .Branch }}-{{ .Revision }}
@@ -154,7 +154,7 @@ jobs:
             # Verify that following commands work, they are later called in the incremental testing script
             # There output does not matter here, the fact that they finish successfully does.
             git rev-parse --abbrev-ref HEAD
-            git fetch --all --tags
+            git fetch --all --tags -f
 
       - attach_workspace:
           at: ~/app
@@ -197,7 +197,8 @@ jobs:
 
   general-test:
     <<: *defaults
-    resource_class: large
+    # XXX (soloseng): Increased size because this test was hitting the ram limit and failing
+    resource_class: xlarge
     steps:
       - attach_workspace:
           at: ~/app
@@ -234,6 +235,7 @@ jobs:
   # crashes on the second re-install.
   # This pre script, generates the build and devchain, and adds it to the workspace to be used for the
   # other script
+
   pre-protocol-test-release:
     <<: *contract-defaults
     resource_class: large
@@ -261,7 +263,6 @@ jobs:
           root: .
           paths:
             - 'packages/protocol/.tmp/released_chain/*'
-
   protocol-test-release:
     <<: *contract-defaults
     resource_class: large
@@ -730,7 +731,7 @@ jobs:
   test-typescript-npm-package-install:
     working_directory: ~/app
     docker:
-      - image: us.gcr.io/celo-testnet/circleci-node12:1.1.0
+      - image: us.gcr.io/celo-testnet/circleci-node18:1.0.0
     steps:
       - run:
           name: Check if the test should run
@@ -743,7 +744,7 @@ jobs:
   test-utils-npm-package-install:
     working_directory: ~/app
     docker:
-      - image: us.gcr.io/celo-testnet/circleci-node12:1.1.0
+      - image: us.gcr.io/celo-testnet/circleci-node18:1.0.0
     steps:
       - run:
           name: Check if the test should run
@@ -756,7 +757,7 @@ jobs:
   test-contractkit-npm-package-install:
     working_directory: ~/app
     docker:
-      - image: us.gcr.io/celo-testnet/circleci-node12:1.1.0
+      - image: us.gcr.io/celo-testnet/circleci-node18:1.0.0
     steps:
       - run:
           name: Check if the test should run
@@ -772,7 +773,7 @@ jobs:
   test-celocli-npm-package-install:
     working_directory: ~/app
     docker:
-      - image: us.gcr.io/celo-testnet/circleci-node12:1.1.0
+      - image: us.gcr.io/celo-testnet/circleci-node18:1.0.0
     steps:
       - run:
           name: Check if the test should run
@@ -992,24 +993,24 @@ workflows:
       - odis-test:
           requires:
             - lint-checks
-      - flakey-test-summary:
-          requires:
-            - protocol-test-common
-            - protocol-test-compatibility
-            - protocol-test-governance-network
-            - protocol-test-governance-validators
-            - protocol-test-governance-voting
-            - protocol-test-identity
-            - protocol-test-stability
-            - end-to-end-geth-transfer-test
-            - end-to-end-geth-blockchain-parameters-test
-            - end-to-end-geth-slashing-test
-            - end-to-end-geth-governance-test
-            - end-to-end-geth-replica-test
-            - end-to-end-geth-sync-test
-            - end-to-end-geth-validator-order-test
-            - end-to-end-cip35-eth-compatibility-test
-            - odis-test
+      # - flakey-test-summary:
+      #     requires:
+      #       - protocol-test-common
+      #       - protocol-test-compatibility
+      #       - protocol-test-governance-network
+      #       - protocol-test-governance-validators
+      #       - protocol-test-governance-voting
+      #       - protocol-test-identity
+      #       - protocol-test-stability
+      #       - end-to-end-geth-transfer-test
+      #       - end-to-end-geth-blockchain-parameters-test
+      #       - end-to-end-geth-slashing-test
+      #       - end-to-end-geth-governance-test
+      #       - end-to-end-geth-replica-test
+      #       - end-to-end-geth-sync-test
+      #       - end-to-end-geth-validator-order-test
+      #       - end-to-end-cip35-eth-compatibility-test
+      #       - odis-test
   npm-install-testing-cron-workflow:
     triggers:
       - schedule:

.github/workflows/circleci.yml

@@ -22,7 +22,7 @@ defaults:
 
 env:
   # Increment these to force cache rebuilding
-  NODE_MODULE_CACHE_VERSION: 2
+  NODE_MODULE_CACHE_VERSION: 3
   NODE_OPTIONS: '--max-old-space-size=4096'
   TERM: dumb
   GRADLE_OPTS: '-Dorg.gradle.daemon=false -Dorg.gradle.parallel=false -Dorg.gradle.configureondemand=true -Dorg.gradle.jvmargs="-Xmx4096m -XX:+HeapDumpOnOutOfMemoryError"'
@@ -40,7 +40,7 @@ jobs:
       # Adding a initial comma so ',<path>' matches also for the first file
       all_modified_files: ",${{ steps.changed-files.outputs.all_modified_files }}"
     # runs-on: ubuntu-latest
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     steps:
       - name: Restore .git cache
@@ -135,7 +135,7 @@ jobs:
       - run: echo ",${{ steps.changed-files.outputs.all_modified_files }}"
   lint-checks:
     name: Lint code
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: install-dependencies
     steps:
@@ -155,7 +155,7 @@ jobs:
       - run: yarn run lint
   general_test:
     name: General jest test
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     needs: install-dependencies
     steps:
       - uses: actions/cache/restore@v3
@@ -189,7 +189,7 @@ jobs:
           path: test-results/jest
   wallet-test:
     name: Wallet test
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: install-dependencies
     steps:
@@ -208,7 +208,7 @@ jobs:
           yarn run lerna --scope '@celo/wallet-*' run test
   pre-protocol-test-release:
     name: Protocol Tests Prepare
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     # Comment lint-checks dependency to speed up (as this is a dependency for many other jobs)
     # needs: [install-dependencies, lint-checks]
@@ -251,7 +251,7 @@ jobs:
           yarn --cwd packages/protocol test:generate-old-devchain-and-build -b $RELEASE_TAG -d .tmp/released_chain -l /dev/stdout -g scripts/truffle/releaseGoldExampleConfigs.json
   protocol-test-release:
     name: Protocol Test Release
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies, lint-checks, pre-protocol-test-release]
     if: |
@@ -282,7 +282,7 @@ jobs:
   protocol-test-matrix:
     # Keeping name short because GitHub UI does not handle long names well 
     name: ${{ matrix.name }}
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 60
     needs: [install-dependencies, lint-checks]
     if: |
@@ -353,7 +353,7 @@ jobs:
             ${{ matrix.command }}
   contractkit-tests:
     name: ContractKit Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies]
     if: |
@@ -381,7 +381,7 @@ jobs:
           yarn --cwd=packages/sdk/contractkit test
   identity-tests:
     name: Identity Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies, contractkit-tests]
     if: |
@@ -409,7 +409,7 @@ jobs:
           yarn --cwd=packages/sdk/identity test
   transactions-uri-tests:
     name: Transaction URI Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies, contractkit-tests]
     if: |
@@ -442,7 +442,7 @@ jobs:
           yarn --cwd=packages/sdk/identity test
   cli-tests:
     name: CeloCli Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies]
     if: |
@@ -481,7 +481,7 @@ jobs:
           yarn --cwd=packages/cli run celocli account:new
   typescript-tests:
     name: Typescript package Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies]
     if: |
@@ -509,7 +509,7 @@ jobs:
           npm install $RUNNER_WORKSPACE/celo-monorepo/packages/typescript/*.tgz
   base-test:
     name: SDK Base package Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies]
     if: |
@@ -543,7 +543,7 @@ jobs:
           npm install $RUNNER_WORKSPACE/celo-monorepo/packages/sdk/base/*.tgz
   utils-test:
     name: SDK Utils package Tests
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies]
     if: |
@@ -576,7 +576,7 @@ jobs:
   end-to-end-geth-matrix:
     # Keeping name short because GitHub UI does not handle long names well
     name: e2e ${{ matrix.name }}
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 60
     needs: [install-dependencies, lint-checks, contractkit-tests]
     if: |
@@ -666,7 +666,7 @@ jobs:
 
   odis-test:
     name: ODIS test
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies, lint-checks]
     if: |
@@ -698,7 +698,7 @@ jobs:
   # NOTE: This has not been fully tested as we don't have a license for certora
   certora-test:
     name: Certora test ${{ matrix.name }}
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     timeout-minutes: 30
     needs: [install-dependencies, lint-checks]
     # Disable as certora license is not active

.github/workflows/cron-protocol-test-with-coverage.yml

@@ -12,7 +12,7 @@ jobs:
   # This seems to take ages and last codecov report is from 2021-02-25 :/
   # https://app.codecov.io/gh/celo-org/celo-monorepo/commits
   protocol-test-with-code-coverage:
-    runs-on: ["self-hosted", "monorepo"]
+    runs-on: ["self-hosted", "monorepo-node18"]
     steps:
       - uses: actions/checkout@v3
       - name: Install yarn dependencies

.nvmrc

@@ -1 +1 @@
-12.22.7
+18.14.2

README-dev.md

@@ -63,7 +63,7 @@ This confirms that it is locally installable and does not have implicit dependen
 ```
 # Specify the package to test. e.g. celocli, contractkit, utils
 celo-monorepo $ PACKAGE=cli
-celo-monorepo $ docker run --rm -v $PWD/packages/${PACKAGE}:/tmp/npm_package -it --entrypoint bash gcr.io/celo-testnet/circleci-node12:1.0.0
+celo-monorepo $ docker run --rm -v $PWD/packages/${PACKAGE}:/tmp/npm_package -it --entrypoint bash gcr.io/celo-testnet/circleci-node18:1.0.0
 circleci@e0d56700584f:/# mkdir /tmp/tmp1 && cd /tmp/tmp1
 circleci@e0d56700584f:/tmp/tmp1# npm install /tmp/npm_package/
 ```
@@ -97,15 +97,15 @@ Once you publish do some manual tests, for example, after publishing `celocli`
 
 ```
 # Docker for an isolated environment again
-celo-monorepo $ docker run --rm -it --entrypoint bash gcr.io/celo-testnet/circleci-node12:1.0.0
+celo-monorepo $ docker run --rm -it --entrypoint bash gcr.io/celo-testnet/circleci-node18:1.0.0
 circleci@7040a7660754:/$ mkdir /tmp/tmp1 && cd /tmp/tmp1
 circleci@7040a7660754:/tmp/tmp1$ npm install @celo/[email protected]
 ...
 circleci@7040a7660754:/tmp/tmp1$ ./node_modules/.bin/celocli
 CLI Tool for transacting with the Celo protocol
 
 VERSION
-  @celo/celocli/0.0.48 linux-x64 node-v12.21.0
+  @celo/celocli/1.6.3 linux-x64 node-v18.14.2
 
 USAGE
   $ celocli [COMMAND]

SECURITY.md

@@ -75,4 +75,5 @@ Open ports without an accompanying proof-of-concept demonstrating vulnerability
 
 ```
 PGP Fingerprint ID: A22B62A5EAFB6948
-```
+```
+

SETUP.md

@@ -42,16 +42,16 @@ Once you have go installed run the following to install gobind
 
 #### Install Node
 
-Currently Node.js v12.x is required in order to work with this repo.
+Currently Node.js v18.14.2 is required in order to work with this repo.
 
 Install `nvm` (allows you to manage multiple versions of Node) by following the [instructions here](https://github.com/nvm-sh/nvm).
 
 Once `nvm` is successfully installed, restart the terminal and run the following commands to install the `npm` versions that [celo-monorepo](https://github.com/celo-org/celo-monorepo) will need:
 
 ```bash
 # restart the terminal after installing nvm
-nvm install 12
-nvm alias default 12
+nvm install 18.14.2
+nvm alias default 18.14.2
 ```
 
 ### MacOS