Onboarding feedback #1811
Merged
Onboarding feedback #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoreton
approved these changes
Nov 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
==========================================
+ Coverage 74.2% 74.21% +<.01%
==========================================
Files 278 278
Lines 7653 7652 -1
Branches 956 957 +1
==========================================
Hits 5679 5679
+ Misses 1857 1856 -1
Partials 117 117
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Nov 26, 2019
* master: (61 commits) [Wallet] Handle `/v/<code` deep links for phone verifications (#1776) Patch tslint auto fix for macOS Catalina until tslint#6.x is out (#1802) Fix typos (#1855) Update documentation sidebar (#1861) [Wallet] Update forno dev documentation (#1818) [Docs] Correct typo Validator UX docs for baklava network (#1688) (#1849) Various improvements to the CLI, allow voters to revote for a group (#1840) Serialize to hex string (#1848) Update faucet to pull from the reserve when possible (#1844) Fix elect validators migration, deploy integration (#1847) Configurable genesis balances (#1838) Deploy new version of Celostats and minnor change from celo-blockchain (#1714) Make default node URL consistent in celocli (#1805) Onboarding feedback (#1811) return at least true, when the function is returning bool (#1825) Minor Contractkit changes (#1819) Point end-to-end tests back to master (#1824) Update migration config to correct protocol parameters (#1822) Update with new istanbul lookback window size flag (#1820) ... # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small updates from my onboarding notes to slightly improve the onboarding process.
Tested
Tested the only code change produces a helpful error in the e2e tests, if for some reason running geth fails. (For me this was due to a failure raising the file descriptor limit.)