Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix OOM error from jest and update Readme #278

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Aug 1, 2019

Description

Attempt to fix OOM errors we're seeing when running tests locally. Based on tips from here:
jestjs/jest#5239

Add some more info around testing to the Readme

Tested

Locally and on Circle. Green ✅

jeanregisser
jeanregisser previously approved these changes Aug 1, 2019
Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looking forward to trying this! 🎉

@jmrossy jmrossy requested a review from ashishb August 1, 2019 14:33
@jmrossy jmrossy changed the title [Wallet] Fix OOM error from jest [Wallet] Fix OOM error from jest and update Readme Aug 1, 2019
Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jmrossy jmrossy merged commit 3fbc799 into master Aug 1, 2019
@jmrossy jmrossy deleted the rossy/wa-jest-mem-fix branch August 1, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants