Merge pull request #311 from celo-org/jcortejoso/op-node-secrets

Don't provide default values for secrets
celo-org · Jun 11, 2024 · 57673b3 · 57673b3
2 parents 7094669 + 1f7e757
commit 57673b3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/charts/op-node/Chart.yaml b/charts/op-node/Chart.yaml
@@ -1,7 +1,7 @@
 ---
 name: op-node
 apiVersion: v2
-version: 0.2.0
+version: 0.2.1
 description: Celo implementation for op-node consensus engine (Optimism Rollup)
 home: https://clabs.co
 sources:

diff --git a/charts/op-node/README.md b/charts/op-node/README.md
@@ -1,6 +1,6 @@
 # op-node
 
-![Version: 0.2.0](https://img.shields.io/badge/Version-0.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.0.0](https://img.shields.io/badge/AppVersion-v1.0.0-informational?style=flat-square)
+![Version: 0.2.1](https://img.shields.io/badge/Version-0.2.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.0.0](https://img.shields.io/badge/AppVersion-v1.0.0-informational?style=flat-square)
 
 Celo implementation for op-node consensus engine (Optimism Rollup)
 Initially based on [dysnix/charts/op-node](https://github.com/dysnix/charts/tree/main/dysnix/op-node).
@@ -107,10 +107,10 @@ Initially based on [dysnix/charts/op-node](https://github.com/dysnix/charts/tree
 | secrets.jwt.value | string | `""` |  |
 | secrets.l1BeaconUrl.secretKey | string | `""` |  |
 | secrets.l1BeaconUrl.secretName | string | `""` |  |
-| secrets.l1BeaconUrl.value | string | `"https://ethereum-beacon-api.publicnode.com"` |  |
+| secrets.l1BeaconUrl.value | string | `""` |  |
 | secrets.l1Url.secretKey | string | `""` |  |
 | secrets.l1Url.secretName | string | `""` |  |
-| secrets.l1Url.value | string | `"https://1rpc.io/eth"` |  |
+| secrets.l1Url.value | string | `""` |  |
 | secrets.p2pKeys.secretKey | string | `""` |  |
 | secrets.p2pKeys.secretName | string | `""` |  |
 | secrets.p2pKeys.value | string | `""` |  |

diff --git a/charts/op-node/ci/ct-values.yaml b/charts/op-node/ci/ct-values.yaml
@@ -4,3 +4,5 @@ secrets:
     value: "1010101010101010101010101010101010101010101010101010101010101010"
   p2pKeys:
     value: "1010101010101010101010101010101010101010101010101010101010101010"
+  l1Url:
+    value: https://1rpc.io/eth
diff --git a/charts/op-node/values.yaml b/charts/op-node/values.yaml
@@ -181,12 +181,12 @@ secrets:
     secretKey: ""
   # REQUIRED: L1 URL. Either provide the secret name and key or the value directly. If value is not empty, it will have precedence over the secret.
   l1Url:
-    value: https://1rpc.io/eth                              # eth L1 node rpc url, can also be ws://
+    value: ""                              # eth L1 node rpc url, can also be ws://
     secretName: ""
     secretKey: ""
   # L1 Beacon URL. Either provide the secret name and key or the value directly. If value is not empty, it will have precedence over the secret.
   l1BeaconUrl:
-    value: https://ethereum-beacon-api.publicnode.com    # endpoint for L1 beacon node, used for retrieving EIP-4844 blob transactions
+    value: ""                             # endpoint for L1 beacon node, used for retrieving EIP-4844 blob transactions
     secretName: ""
     secretKey: ""