Merge pull request #298 from celo-org/jcortejoso/op-node-ips

Renaming advertiseIP to advertiseIPs
celo-org · Jun 6, 2024 · 64abcf9 · 64abcf9
2 parents d6330e4 + edfb757
commit 64abcf9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/charts/op-node/Chart.yaml b/charts/op-node/Chart.yaml
@@ -1,7 +1,7 @@
 ---
 name: op-node
 apiVersion: v2
-version: 0.1.0
+version: 0.1.1
 description: Celo implementation for op-node consensus engine (Optimism Rollup)
 home: https://clabs.co
 sources:

diff --git a/charts/op-node/README.md b/charts/op-node/README.md
@@ -1,6 +1,6 @@
 # op-node
 
-![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.0.0](https://img.shields.io/badge/AppVersion-v1.0.0-informational?style=flat-square)
+![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v1.0.0](https://img.shields.io/badge/AppVersion-v1.0.0-informational?style=flat-square)
 
 Celo implementation for op-node consensus engine (Optimism Rollup)
 Initially based on [dysnix/charts/op-node](https://github.com/dysnix/charts/tree/main/dysnix/op-node).
@@ -40,7 +40,7 @@ Initially based on [dysnix/charts/op-node](https://github.com/dysnix/charts/tree
 | config.metrics.enabled | bool | `false` |  |
 | config.metrics.port | int | `7300` |  |
 | config.network | string | `"op-mainnet"` |  |
-| config.p2p.advertiseIP | string | `""` |  |
+| config.p2p.advertiseIPs | string | `""` |  |
 | config.p2p.bootnodes | list | `[]` |  |
 | config.p2p.keys | string | `""` |  |
 | config.p2p.nat | bool | `false` |  |

diff --git a/charts/op-node/templates/scripts/_split-config-parameters.tpl b/charts/op-node/templates/scripts/_split-config-parameters.tpl
@@ -25,7 +25,7 @@ if [ -f /secrets/sequencer.hex ]; then
 fi
 
 # Split the advertised addresses based on the comma and get the $RID-th key
-advertiseIp=$(echo "{{ .Values.config.p2p.advertiseIP }}" | tr ',' '\n' | sed -n "$((RID + 1))p" | tr -d '\n')
+advertiseIp=$(echo "{{ .Values.config.p2p.advertiseIPs }}" | tr ',' '\n' | sed -n "$((RID + 1))p" | tr -d '\n')
 # Check if not empty
 if [ -n "$advertiseIp" ]; then
   echo "Setting advertise address to $advertiseIp"

diff --git a/charts/op-node/values.yaml b/charts/op-node/values.yaml
@@ -195,7 +195,7 @@ config:
     port: 7300
   p2p:
     nat: false                         # use NAT to get external IP
-    advertiseIP: ""                    # override announced p2p IP
+    advertiseIPs: ""                   # override announced p2p IP. Commas separated list of IPs
     port: 9222
     useHostPort: false                 # use hostPort for p2p traffic instead of dedicated k8s svc
     bootnodes: []                      # override bootnodes