fix client.py to work with python3.4+ #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah, sorry. I have some of these exact same changes in my local tree but didn't clean them up and push them yet. |
cemeyer
reviewed
Jan 22, 2019
| @@ -51,11 +51,11 @@ def parse_ServerResponse(self, response): | |||
| assert x.tag == '{http://schemas.xmlsoap.org/soap/envelope/}Envelope' | |||
| r = x.find('.//{http://ctkipservice.rsasecurity.com}' + outer) | |||
| ad = r.find('{http://ctkipservice.rsasecurity.com}AuthData') | |||
| assert ad.text == self.auth == response.headers.get('Authorization') | |||
| #assert ad.text == self.auth == response.headers.get('Authorization') | |||
There was a problem hiding this comment.
My server doesn't send Authorization either, but for me the ad.text == self.auth assertion still held. Does it not for you?
| @@ -122,17 +122,24 @@ def serverFinished(self, session_id, server_nonce, client_none=None): | |||
| if client_none is None: | |||
| client_nonce = random.getrandbits(16*8) | |||
| cipher = PKCS1_OAEP.new(self.server_pubkey) | |||
| client_nonce = client_nonce.to_bytes(16, byteorder='big') | |||
There was a problem hiding this comment.
Oh, that's a lot better than what I have (bytes(bytearray([random.getrandbits(8) for i in range(16)]))).
|
FYI: basically same as dlenski#1 |
rgerganov
pushed a commit
to rgerganov/rsa_ct_kip
that referenced
this pull request
Jan 23, 2019
Fixing runtime errors encountered using python3
|
Not needed anymore. |
rgerganov
pushed a commit
to rgerganov/rsa_ct_kip
that referenced
this pull request
Feb 13, 2019
Fixing runtime errors encountered using python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.