feat: support native SSL certs as well #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables looking for certs in the local setup in addition to the already used Mozilla certs. In particular this will now also respect SSL_CERT_FILE for custom cert files. In effect, it will allow to deal with deployment scenarios that require custom SSL certs.
|
Note that this currently pulls in two versions of the native-certs crate, this is fixed in reqwest head (seanmonstar/reqwest#2427), but not released yet. Happy for this to wait little bit, maybe there'll be a new reqwest version soon. |
|
Happy to merge this now. I'll create an issue to wait for the next release of reqwest. |
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables looking for certs in the local setup in addition to the already used Mozilla certs. In particular this will now also respect SSL_CERT_FILE for custom cert files. In effect, it will allow to deal with deployment scenarios that require custom SSL certs.