Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Update google format dependency and use protobuf json marshaler. #14

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

HailongWen
Copy link
Contributor

This PR addresses the following issues:

  1. use golang/protobuf/jsonpub as marshaler/unmarshaler - the default encoding/json cannot handle camelCase json generated by Java server.
  2. update the dependency of google cloud-trace format since it is moved to another package (Begin moving Google Cloud Trace format to the stackdriver package census-instrumentation/opencensus-go#555).

Though this change is tested locally, it is my first time writing in Golang. Please pardon me if I make any mistakes :)

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HailongWen HailongWen merged commit e8396aa into census-ecosystem:master Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants