Data race in ApplyConfig (#763)

Oddly, I could not get the race detector to find this.
census-instrumentation · May 25, 2018 · c3ed530 · c3ed530
1 parent a658407
commit c3ed530
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/trace/config.go b/trace/config.go
@@ -29,12 +29,12 @@ type Config struct {
 //
 // Fields not provided in the given config are going to be preserved.
 func ApplyConfig(cfg Config) {
-	c := config.Load().(*Config)
+	c := *config.Load().(*Config)
 	if cfg.DefaultSampler != nil {
 		c.DefaultSampler = cfg.DefaultSampler
 	}
 	if cfg.IDGenerator != nil {
 		c.IDGenerator = cfg.IDGenerator
 	}
-	config.Store(c)
+	config.Store(&c)
 }