Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Create a zipkin example #531

Closed
victormn opened this issue Mar 7, 2018 · 3 comments
Closed

Create a zipkin example #531

victormn opened this issue Mar 7, 2018 · 3 comments
Labels

Comments

@victormn
Copy link

victormn commented Mar 7, 2018

We already have a Jeager example of tracing. Could you write a Zipkin example, please?

@odeke-em
Copy link
Member

odeke-em commented Mar 7, 2018

Hello there @victormn, thank you for the request and welcome to OpenCensus!

So we have an example test in

package zipkin_test
import (
"log"
openzipkin "github.com/openzipkin/zipkin-go"
"github.com/openzipkin/zipkin-go/reporter/http"
"go.opencensus.io/exporter/zipkin"
"go.opencensus.io/trace"
)
func Example() {
// import (
// openzipkin "github.com/openzipkin/zipkin-go"
// "github.com/openzipkin/zipkin-go/reporter/http"
// "go.opencensus.io/exporter/trace/zipkin"
// )
localEndpoint, err := openzipkin.NewEndpoint("server", "192.168.1.5:5454")
if err != nil {
log.Print(err)
}
reporter := http.NewReporter("http://localhost:9411/api/v2/spans")
exporter := zipkin.NewExporter(reporter, localEndpoint)
trace.RegisterExporter(exporter)
}

However, if you'd like to create a conventional example like Jaeger's in the example's directory, you are more than welcome and I'll tag other teammates @Ramonza @rakyll.

@freddygv
Copy link
Contributor

freddygv commented Mar 9, 2018

Hi, I was planning on adding this. Will get a PR in this weekend.

@odeke-em
Copy link
Member

odeke-em commented Mar 9, 2018

Perfect, thank you again @freddygv!

freddygv added a commit to freddygv/opencensus-go that referenced this issue Mar 18, 2018
@rakyll rakyll closed this as completed in 2869e62 Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants