Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Span.SetAttributes sounds like it replaces all attributes #571

Closed
semistrict opened this issue Mar 13, 2018 · 1 comment
Closed

Span.SetAttributes sounds like it replaces all attributes #571

semistrict opened this issue Mar 13, 2018 · 1 comment
Assignees
@rakyll
Labels
api-breaking trace

Comments

@semistrict
Copy link
Contributor

Maybe we should rename it Span.AddAttributes or Span.MergeAttributes?
@rakyll
Copy link
Contributor

rakyll commented Mar 16, 2018

+1 to AddAttributes.

@rakyll rakyll self-assigned this Mar 16, 2018
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 16, 2018
@rakyll
Rename SetAttributes to AddAttributes
dc9866e 
Fixes census-instrumentation#571.
@rakyll rakyll mentioned this issue Mar 16, 2018
Merged
rakyll added a commit that referenced this issue Mar 16, 2018
@rakyll
Rename SetAttributes to AddAttributes (#595)
90cbf26 
Fixes #571.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakyll rakyll

Labels
api-breaking trace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakyll @semistrict