This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add support for Tag metadata #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Apr 23, 2019
| @@ -95,13 +100,14 @@ type Mutator interface { | |||
| // Insert returns a mutator that inserts a | |||
| // value associated with k. If k already exists in the tag map, | |||
| // mutator doesn't update the value. | |||
| func Insert(k Key, v string) Mutator { | |||
| // Metadata applies metadata to the tag. It is optional. | |||
There was a problem hiding this comment.
What if there're more than one metadatas and they're conflicting? E.g Insert(k, v, unlimitedPropagation, noPropagation)?
There was a problem hiding this comment.
the last one will be effective.
There was a problem hiding this comment.
Consider adding a note on the API document, and adding a few tests on this case.
There was a problem hiding this comment.
added a note in the apis and testcases.
songy23
approved these changes
Apr 23, 2019
| @@ -95,13 +100,14 @@ type Mutator interface { | |||
| // Insert returns a mutator that inserts a | |||
| // value associated with k. If k already exists in the tag map, | |||
| // mutator doesn't update the value. | |||
| func Insert(k Key, v string) Mutator { | |||
| // Metadata applies metadata to the tag. It is optional. | |||
There was a problem hiding this comment.
Consider adding a note on the API document, and adding a few tests on this case.
songy23
approved these changes
Apr 23, 2019
rghetia
added a commit
to rghetia/opencensus-go
that referenced
this pull request
Apr 25, 2019
* Add support for tag metadata. * update ocgrpc and ochttp to use new insert/update/upsert api. : * updated existing method optional metadata option. * make TTLNoPropagation and TTLUnlimitedPropagation a function. * changed ttl api. * add test case for multiple TTL metadata. * add test case and note for update/insert api.
rghetia
added a commit
that referenced
this pull request
Apr 25, 2019
* Add support for tag metadata. * update ocgrpc and ochttp to use new insert/update/upsert api. : * updated existing method optional metadata option. * make TTLNoPropagation and TTLUnlimitedPropagation a function. * changed ttl api. * add test case for multiple TTL metadata. * add test case and note for update/insert api.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1032