This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Cleanup the ochttp package #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several reorganization related and readability improvements.
odeke-em
approved these changes
Mar 8, 2018
| if !h.NoTrace { | ||
| var end func() | ||
| r, end = h.startTrace(w, r) | ||
| defer end() |
There was a problem hiding this comment.
Aha, I like this, I read the previous code on my way back home and had the urge for this kind of change, so thank you!
| } | ||
|
|
||
| span.SetAttributes(requestAttrs(r)...) | ||
| return r.WithContext(trace.WithSpan(r.Context(), span)), span.End |
There was a problem hiding this comment.
Nice, thanks for changing it from func() { span.End } to span.End!
| writer http.ResponseWriter | ||
| } | ||
|
|
||
| var _ http.ResponseWriter = (*trackingResponseWriter)(nil) |
| start time.Time | ||
| statusCode int | ||
| endOnce sync.Once | ||
| writer http.ResponseWriter |
There was a problem hiding this comment.
writer seems quite ambigious for the field of http.ResponseWriter.
How about either of?
- rw
- responseWriter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several reorganization related and readability improvements.