This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Clean up ocgrpc: remove NewXXXStatsHandler methods #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
changed the title
semistrict
changed the title
rakyll
reviewed
Mar 9, 2018
| @@ -44,7 +44,7 @@ func main() { | |||
|
|
|||
| // Set up a connection to the server with the OpenCensus | |||
| // stats handler to enable stats and tracing. | |||
| conn, err := grpc.Dial(address, grpc.WithStatsHandler(ocgrpc.NewClientStatsHandler()), grpc.WithInsecure()) | |||
| conn, err := grpc.Dial(address, grpc.WithStatsHandler(new(ocgrpc.ClientHandler)), grpc.WithInsecure()) | |||
There was a problem hiding this comment.
This is not a common style in Go for inline code.
It is somewhat encouraged with var for zero values:
var hander = new(ocgrpc.ClientHandler)
Use &ocgrpc.ClientHandler{} instead.
| @@ -59,7 +59,7 @@ func main() { | |||
|
|
|||
| // Set up a new server with the OpenCensus | |||
| // stats handler to enable stats and tracing. | |||
| s := grpc.NewServer(grpc.StatsHandler(ocgrpc.NewServerStatsHandler())) | |||
| s := grpc.NewServer(grpc.StatsHandler(new(ocgrpc.ServerHandler))) | |||
plugin/ocgrpc/grpc_test.go
Outdated
| te := &traceExporter{} | ||
| trace.RegisterExporter(te) | ||
| func TestClientHandler(t *testing.T) { | ||
| var ( |
There was a problem hiding this comment.
Remove the var grouping here.
plugin/ocgrpc/grpc_test.go
Outdated
| te := &traceExporter{} | ||
| trace.RegisterExporter(te) | ||
| func TestServerHandler(t *testing.T) { | ||
| var ( |
semistrict
force-pushed
the
remove-new-handler
branch
from
32c48a9
to
410fb67
Compare
|
@rakyll PTAL |
rakyll
approved these changes
Mar 12, 2018
plugin/ocgrpc/grpc_test.go
Outdated
| span := trace.NewSpan("/foo", nil, trace.StartOptions{ | ||
| Sampler: trace.AlwaysSample(), | ||
| }) | ||
| ctx = trace.WithSpan(ctx, span) | ||
|
|
||
| var handler ServerHandler |
There was a problem hiding this comment.
handler := &ServerHandler{}
plugin/ocgrpc/grpc_test.go
Outdated
| te := &traceExporter{} | ||
| trace.RegisterExporter(te) | ||
| if err := ServerRequestCountView.Subscribe(); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| // Ensure we start tracing |
There was a problem hiding this comment.
// Ensure we start tracing.
End with full stop. In Go, block comments are proper English sentences, side comments can be non-proper sentences. For example:
ctx = trace.WithSpan(ctx, span) // span in the context
Since we provide options on the ClientHandler and ServerHandler structs and the NewXXX methods were trivial, it is better to have users use a struct literal.
semistrict
force-pushed
the
remove-new-handler
branch
from
410fb67
to
e0b3e58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we provide options on the ClientHandler and ServerHandler structs
and the NewXXX methods were trivial, it is better to have users use a
struct literal.