This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Remove deprecated trace.StartSpanWithXXX convenience methods #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Mar 9, 2018
plugin/ocgrpc/grpc_test.go
Outdated
|
|
||
| te := &traceExporter{} | ||
| trace.RegisterExporter(te) | ||
| var ( |
There was a problem hiding this comment.
Can you revert these changes?
In Go, this style is discouraged. var grouping is mostly discouraged unless the variables need to be strictly grouped together for readability. var is entirely discouraged unless it is for the zero value.
plugin/ocgrpc/trace_common.go
Outdated
| md, _ := metadata.FromIncomingContext(ctx) | ||
| name := "Recv" + strings.Replace(rti.FullMethodName, "/", ".", -1) | ||
| func (sh *serverTraceHandler) TagRPC(ctx context.Context, rti *stats.RPCTagInfo) context.Context { | ||
| var ( |
semistrict
force-pushed
the
remove-span-start-methods
branch
from
1988c69
to
a250d24
Compare
semistrict
commented
Mar 9, 2018
| @@ -59,7 +59,7 @@ func main() { | |||
|
|
|||
| // Set up a new server with the OpenCensus | |||
| // stats handler to enable stats and tracing. | |||
| s := grpc.NewServer(grpc.StatsHandler(ocgrpc.NewServerStatsHandler())) | |||
There was a problem hiding this comment.
This should be in the other PR
semistrict
force-pushed
the
remove-span-start-methods
branch
from
a250d24
to
9618dbf
Compare
|
@rakyll PTAL |
rakyll
approved these changes
Mar 9, 2018
plugin/ocgrpc/trace_common.go
Outdated
| if s := md[traceContextKey]; len(s) > 0 { | ||
| if parent, ok := propagation.FromBinary([]byte(s[0])); ok { | ||
| ctx, _ = trace.StartSpanWithRemoteParent(ctx, name, parent, trace.StartOptions{}) | ||
| return ctx | ||
| span = trace.NewSpanWithRemoteParent(name, parent, trace.StartOptions{}) |
There was a problem hiding this comment.
I'd move ctx = trace.WithSpan(ctx, span) after this line and return.
if s := md[traceContextKey]; len(s) > 0 {
if parent, ok := propagation.FromBinary([]byte(s[0])); ok {
span := trace.NewSpanWithRemoteParent(name, parent, trace.StartOptions{})
return trace.WithSpan(ctx, span)
}
}
ctx, _ = trace.StartSpan(ctx, name)
return
9618dbf
to
9b97f91
Compare
semistrict
pushed a commit
to semistrict/opencensus-go
that referenced
this pull request
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.