This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Make stats.{Int,Float}64 never return errors #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
force-pushed
the
remove-measure-error
branch
from
4fbfd4d
to
af3ceb9
Compare
semistrict
force-pushed
the
remove-measure-error
branch
from
af3ceb9
to
1e6931c
Compare
rakyll
approved these changes
Mar 21, 2018
stats/measure_float64.go
Outdated
| // an error if a measure with the same name already exists. | ||
| // Float64 creates a new measure of type Float64Measure. | ||
| // It never returns an error. | ||
| //TODO(ramonza): remove error |
stats/measure_int64.go
Outdated
|
|
||
| func (i *Int64Measure) subscribed() bool { | ||
| return i.measure.subscribed() | ||
| Measure |
stats/measure_int64.go
Outdated
| // error if a measure with the same name already exists. | ||
| // Int64 creates a new measure of type Int64Measure. | ||
| // It never returns an error. | ||
| //TODO(ramonza): remove error |
semistrict
force-pushed
the
remove-measure-error
branch
4 times, most recently
from
bd69b82
to
44dc4a2
Compare
|
@rakyll removed the embedding, PTAL |
rakyll
approved these changes
Mar 22, 2018
semistrict
force-pushed
the
remove-measure-error
branch
from
44dc4a2
to
9a55159
Compare
semistrict
force-pushed
the
remove-measure-error
branch
from
9a55159
to
371a1f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the error in the signature for now since it's used externally. We should remove it in the next round of deprecation removals.
Updates: #544