This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Allow configuring ochttp.Handler for public servers #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should similarly give user a way to label a public server instead of dropping default propagation support. By default, we don't want to drop the traces. |
semistrict
force-pushed
the
ochttp-no-default-propagate
branch
from
f883749
to
0d1a33f
Compare
semistrict
changed the title
semistrict
force-pushed
the
ochttp-no-default-propagate
branch
4 times, most recently
from
8ed1dd7
to
c996638
Compare
|
@rakyll updated PTAL |
Added a flag on ochttp.Handler that causes the incoming SpanContext to be added as a link rather than a parent. This is useful if we don't trust the metadata.
semistrict
force-pushed
the
ochttp-no-default-propagate
branch
from
c996638
to
b0a41c6
Compare
rakyll
approved these changes
Mar 16, 2018
plugin/ochttp/trace_test.go
Outdated
| trace.SetDefaultSampler(trace.AlwaysSample()) | ||
|
|
||
| cases := []struct { | ||
| Name string |
There was a problem hiding this comment.
No need to export these fields.
name string
plugin/ochttp/trace_test.go
Outdated
|
|
||
| cases := []struct { | ||
| Name string | ||
| ServerMiddleware *Handler |
plugin/ochttp/trace_test.go
Outdated
| cases := []struct { | ||
| Name string | ||
| ServerMiddleware *Handler | ||
| ClientMiddleware *Transport |
plugin/ochttp/trace_test.go
Outdated
| Name string | ||
| ServerMiddleware *Handler | ||
| ClientMiddleware *Transport | ||
| ExpectSameTraceID bool |
plugin/ochttp/trace_test.go
Outdated
| ServerMiddleware *Handler | ||
| ClientMiddleware *Transport | ||
| ExpectSameTraceID bool | ||
| ExpectLinks bool // expect a link between client and server span |
plugin/ochttp/trace_test.go
Outdated
| } | ||
|
|
||
| serverReturn <- time.Now().Add(time.Millisecond) | ||
| for _, c := range cases { |
There was a problem hiding this comment.
In Go, it is canonical to name cases tc, and specific case tt.
It improves readability to use tt because everyone knows it represents the current test case without having to jump to the declaration.
plugin/ochttp/trace_test.go
Outdated
| req = req.WithContext(ctx) | ||
| resp, err := c.ClientMiddleware.RoundTrip(req) | ||
| if err != nil { | ||
| t.Fatalf("unexpected error %s", err) |
plugin/ochttp/trace_test.go
Outdated
| t.Fatalf("unexpected error %s", err) | ||
| } | ||
| if resp.StatusCode != http.StatusOK { | ||
| t.Fatalf("unexpected stats: %d", resp.StatusCode) |
There was a problem hiding this comment.
t.Fatalf("resp.StatusCode = %v, ...)
The unexpected terminology doesn't exist in Go.
plugin/ochttp/trace_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("unexpected read error: %#v", err) | ||
| } | ||
| if string(respBody) != "expected-response" { |
There was a problem hiding this comment.
if got, want := string(respBody), "expected"; got != want {
t.Fatalf("Response body = %q; want %q", got, want)
}
plugin/ochttp/server.go
Outdated
| ctx := r.Context() | ||
| var span *trace.Span | ||
| if sc, ok := p.SpanContextFromRequest(r); ok { | ||
| sc, haveSC := h.extractSpanContext(r) |
There was a problem hiding this comment.
sc, ok := h..extractSpanContext(r)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.