Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Make Sampler a function #564

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Make Sampler a function #564

merged 1 commit into from
Mar 12, 2018

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Mar 12, 2018

Fixes #490.

@rakyll
Copy link
Contributor Author

rakyll commented Mar 12, 2018

I don't think this change adds much value. I am not going to merge it if it sounds good to you.

semistrict
semistrict approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@semistrict semistrict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this. It's a net win (also net-red).

@rakyll rakyll merged commit f1af72a into census-instrumentation:master Mar 12, 2018
@rakyll rakyll deleted the sampler branch March 12, 2018 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@semistrict semistrict semistrict approved these changes

@odeke-em odeke-em Awaiting requested review from odeke-em

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakyll @semistrict